I'm not sure about the icon in the footer of the tooltip, I do think the checking for mouse or touch event is good, mind if I take that out to put in the 2024.2 release?

That icon is a "button" on mobile, however it is not visible on desktop (when hovering the mouse pointer). On mobile, you may still tap anywhere else on the tooltip and have it propagate to the chart (to choose a different chart data point). Not having this button and only reacting to a tap on the tooltip would be bad UX-wise because it would prevent you from selecting other chart data points that are under it.

But I know that (i) icon is not the nicest thing. It expects that people would find out that it is tappable which I am not 100% sure. On the other hand, there is (i) on other places in HA, I use (i) in Developer Tools/States regularly. There are not that many alternative options. One option would be to have a link there with "More Info" text or something like that, I tried this initially but it looked too "noisy". I haven't tried to make its font smaller, though, but still, having a clickable link on tooltip seems worse to me.

As for me, I'm fine with the existing situation (without this PR), however other people complained in the connected problems, so I created this PR to make them happier. I'm not sure whether they are the majority. On the other hand, it really seem unusual that tapping on a chart opens a dialog.. I believe this PR will make everyone pleased, but I cannot guarantee it.

Removing access to More info on mobile entirely will make me force to use the current HA version forever (or update my personal fork every couple of years). But I can live with that, too. So whatever, you are the boss. :)

I think putting an actionable item in the tooltip will always be a problem, as it might not be expected and could prevent the user from interacting with the chart, especially on small charts with big tooltips.

I will discuss this with our UX team.

@matthiasdebaat

This is fantastic! I really dislike needing to hold and wait before releasing my finger when trying to read a value off the history graphs on mobile. If I release too early it jumps into the more info page of the entity I was already looking at. Leads to a loop of history -> info -> history -> info when I'm just trying to see the value of the graph at a specific point in time.
Tapping a button on the tooltip is great for mobile imo.

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

Still would very much like to see this functionality.
While the recent changes that prevent accidentally opening the info page when reading values on graphs is great, it was very annoying accidentally doing that, now there isn't a way to do it intentionally on mobile at all. You now need to find the entity manually on another page or have an additional card.
An optional (i) button, or something equivalent, that lets you open the info page would be very nice.

Thanks @k3a for this PR! I've looked into this from a UX point of view. The problem, as I see it, is that it's not clear what will happen when you tap the graph on mobile. Our users would assume what would happen based on experience and different mental models. We have two options:

• Open the more-info dialog for more details about the entity.
• Show tooltip, which shows more accurate detailed information on the graph itself.

In the case of our history graph card, you can have multiple entities on one card. Right now, the more-info dialog of an entity opens when you tap the right little line. This is consistent with the design pattern that opens up more-info about an entity when you tap anywhere other than the action. But I think we should be coherent here.

I agree with your PR to always show the tooltip on tap. The primary function of the card is to display and compare data. Next step could be to get more details about the entity. Currently we break this flow.

I like that you made a difference between tap and click devices. Design wise I would suggest to have a clear label instead of the (i) icon. For example the text button with the label More info.

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?